feat: add info_filename field to sample_data table#175
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new info_filename field to the SampleData schema class to support tracking metadata file paths for samples. The change enables the system to associate each sample with its corresponding metainfo data blob stored on disk.
- Added
info_filenamestring field with empty string default toSampleDataclass - Updated class docstring to document the new field's purpose
- Implemented proper type validation using
validators.instance_of(str)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ktro2828
left a comment
ktro2828
left a comment
There was a problem hiding this comment.
@SamratThapa120 Thank you for PR! I left a comment about the default value of the new field. Please take a look.
github-actions
Bot
added
the
ci
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
…into feat/schmea/sensor_info
SamratThapa120
force-pushed
the
feat/schmea/sensor_info
branch
from
139386f to
43de74b
Compare
|
@ktro2828 I cannot merge this branch, likely because of the main branch protection rules? |
|
@SamratThapa120 I updated the branch rules, how about now? |
|
@ktro2828 Thanks. Merged 😍 |
This pull request introduces a minor schema update to the
SampleDataclass int4_devkit/schema/tables/sample_data.pyto support tracking additional metadata for each sample. The most important change is the addition of a new field for storing the relative path to associated metainfo data.Schema enhancements:
info_filenameto theSampleDataclass, which stores the relative path to metainfo data-blobs on disk. This field is now part of both the docstring and the class definition, with a default value of an empty string and appropriate type validation. [1] [2]This field will point to the ConcatenatedPointCloudInfo file which contains information about the lidar indices, timestamps, and other meta info for the concatenated pointcloud.
References:
tier4/tier4_perception_dataset#255